As for OP's question, I haven't yet changed my weaponlight CR123 batteries for years, and it works great.
It is really difficult to predict when the batteries would go dead, because usages and capacities of batteries are all different.
Most frequent used flashlight uses rechargeable batteries, and my backup batteries are non-rechargeable (longer shelf-life).